Skip to content

Ocp admin/multi cluster report - automatic authentication mechanism#27

Merged
dmartinol merged 13 commits into
mainfrom
ocp-admin/multi-cluster-report
Mar 9, 2026
Merged

Ocp admin/multi cluster report - automatic authentication mechanism#27
dmartinol merged 13 commits into
mainfrom
ocp-admin/multi-cluster-report

Conversation

@ikrispin

@ikrispin ikrispin commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-support-engineer
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (.mcp.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@ikrispin ikrispin requested review from dmartinol and r2dedios March 5, 2026 12:50
@ikrispin ikrispin changed the title Ocp admin/multi cluster report Ocp admin/multi cluster report - automatic authentication mechanism Mar 5, 2026
r2dedios
r2dedios approved these changes Mar 5, 2026
View reviewed changes

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/docs/multi-cluster-auth.md
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/docs/multi-cluster-auth.md
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/scripts/cluster-report/build-kubeconfig.sh Outdated
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/scripts/cluster-report/build-kubeconfig.sh Outdated
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/scripts/cluster-report/build-kubeconfig.sh Outdated
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes
Comment thread ocp-admin/.mcp.json Outdated
dmartinol
dmartinol reviewed Mar 5, 2026
View reviewed changes

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea 👍 I'd like to see it in action.
I think it deserves an ad-hoc scale test with mock servers to prove show numbers.

ikrispin added 11 commits March 8, 2026 14:06
@ikrispin
add explicit rule to never display tokens in AI conversations
765465d
@ikrispin
docs: clarified the admin permission level as a prerequisite
fa0b9a1
@ikrispin
extrat python setup and build scripts
e872bc5
@ikrispin
refactor: consolidate scripts into a single python script
87e990f
@ikrispin
Rename plugin from 'OpenShift Administration Agentic Skills Collectio…
3565def 
…n' to 'ocp-admin'
@ikrispin
add skip-rbac flag for when it's already applied for extracting exist…
634969e 
…ing SA token and fix plugin name
@ikrispin
add pre-flight checks for fail-fast in case of missing prerequisites
e791d36
@ikrispin
update find_kube_cmd() to prefer oc and warn on kubectl fallback
26d4a87
@ikrispin
add a bash wrapper to podman to conditionally add --userns only on Linux
f8ce472
@ikrispin
Merge remote-tracking branch 'origin' into ocp-admin/multi-cluster-re…
2866a56 
…port
@ikrispin
Merge branch 'ocp-admin/multi-cluster-report' of github.com:RHEcosyst…
35e40fa 
…emAppEng/agentic-collections into ocp-admin/multi-cluster-report
dmartinol
dmartinol approved these changes Mar 9, 2026
View reviewed changes

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dmartinol dmartinol merged commit b2f95ba into main Mar 9, 2026
2 checks passed
@ikrispin ikrispin deleted the ocp-admin/multi-cluster-report branch March 10, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r2dedios r2dedios r2dedios approved these changes
@dmartinol dmartinol dmartinol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikrispin @r2dedios @dmartinol